[SYCL] Add asan AOT libdevice for different GPU/CPU #15939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP, need to add driver lit test. |
Add corresponding device asan libdevice for 3 CPU, PVC, DG2 AOT targets Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
|
Hi, @mdtoguchi |
Signed-off-by: jinge90 <[email protected]>
mdtoguchi
reviewed
Oct 31, 2024
jinge90
commented
Nov 1, 2024
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
mdtoguchi
reviewed
Nov 1, 2024
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
mdtoguchi
reviewed
Nov 4, 2024
| // RUN: | FileCheck %s -check-prefix=SYCL_DEVICE_LIB_ASAN_DG2 | ||
| // RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xs "-device dg2" --no-offload-new-driver %s \ | ||
| // RUN: --sysroot=%S/Inputs/SYCL -Xarch_device -fsanitize=address -### 2>&1 \ | ||
| // RUN: | FileCheck %s -check-prefix=SYCL_DEVICE_LIB_ASAN_DG2 |
There was a problem hiding this comment.
Please add a test for -fsycl-targets=intel_gpu_dg2*
There was a problem hiding this comment.
Hi, @mdtoguchi
Done.
Thanks very much.
Signed-off-by: jinge90 <[email protected]>
AllanZyne
approved these changes
Nov 5, 2024
mdtoguchi
approved these changes
Nov 5, 2024
|
Hi, @cperkinsintel |
cperkinsintel
approved these changes
Nov 8, 2024
|
Hi, @intel/llvm-gatekeepers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device address sanitizer libraries can be optimized in AOT compilation mode, some redundant code checking which device current kernel is running on can be removed. This PR creates corresponding AOT address sanitizer device libraries for CPU, PVC, DG2 target and link them according to real AOT target. This PR also renames previous libsycl-sanitizer to libsycl-asan since current device sanitizer only supports address sanitizer and memory sanitizer will be added in the future.
Signed-off-by: jinge90 [email protected]